rexport dependencies #543
Open
rexport dependencies #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Owner
|
Hi @KutnerUri thanks for your contribution. The default parser is actually just a function from: https://github.com/lukeed/regexparam Would it make sense to mention it in the README instead of exporting (e.g. "the default value of |
Author
|
yes, I ended up using that, but it seems like an implicit dependency, I'd rather use the exact same tooling as wouter. I was working on a wrapper that adds entry and exist animations, I only needed that to use matchRoute(), which was quite inconvenient. you can see the original code here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's no way to use the default parser outside of
useRouter(). this PR exposes it